kern/75482: bug in fwohci_pci.c causes cdrom installation to fail

[Michael W.Oliver]

>Number:         75482
>Category:       kern
>Synopsis:       bug in fwohci_pci.c causes cdrom installation to fail
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 25 06:50:21 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Michael W. Oliver
>Release:        FreeBSD 5.3-RELEASE amd64
>Organization:
n/a
>Environment:

no `uname' available since installation panics

>Description:

fwohci0: <Texas Instruments TSB43AB21/A/AI/A-EP> mem 0xd0000000-0xd0003fff,0xd0008000-0xd00087ff irq 17 at device 6.0 on pci0
fwohci0: Reserved 0x800 bytes for rid 0x10 type 3 at 0xd0008000
fwohci0: [MPSAFE]
fwohci0: OHCI version 1.10 (ROM=1)
NMI ISA b0, EISA ff
RAM parity error, likely hardware failure.

Fatal trap 19: non-maskable interrupt trap while in kernel mode
instruction pointer     = 0x8:0xffffffff8024db66
stack pointer           = 0x10:0xffffffff80c99950
frame pointer           = 0x10:0xffffffff80e39000
code segment            = base 0x0, limit 0xfffff, type 0x1b
                        = DPL 0, pres 1, long 1, def32 0, gran 1
processor eflags        = interrupt enabled, IOPL = 0
current process         = 0 (swapper)
trap number             = 19
panic: non-maskable interrupt trap
Uptime: 1s
Shutting down ACPI
Automatic reboot in 15 seconds - press a key on the console to abort

>How-To-Repeat:

boot a system with the TSB43AB21/A/AI/A-EP firewire controller with a
5.3-RELEASE iso

>Fix:

the hint to this fix was found on the dfly list via google, and the fix
was done by simokawa at freebsd.org.  I am just submitting it here so that
it gets applied to the FreeBSD tree.

(this patch is actually against RELENG_5)
(also, this is my first PR, so if I screwed something up, please let me
know so that I don't do it again)

Index: sys/dev/firewire/fwohci_pci.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/firewire/fwohci_pci.c,v
retrieving revision 1.48
diff -u -r1.48 fwohci_pci.c
--- sys/dev/firewire/fwohci_pci.c	4 Aug 2004 12:18:39 -0000	1.48
+++ sys/dev/firewire/fwohci_pci.c	25 Dec 2004 05:51:53 -0000
@@ -241,6 +241,7 @@
 		PCIM_CMD_SERRESPEN | PCIM_CMD_PERRESPEN;
 #if 1
 	cmd &= ~PCIM_CMD_MWRICEN; 
+	cmd &= ~(PCIM_CMD_SERRESPEN | PCIM_CMD_PERRESPEN);
 #endif
 	pci_write_config(self, PCIR_COMMAND, cmd, 2);


>Release-Note:
>Audit-Trail:
>Unformatted: