bin/70960: "ndc restart" dumps core when named is running with options

[SANETO Takanori]

>Number:         70960
>Category:       bin
>Synopsis:       "ndc restart" dumps core when named is running with options
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 25 23:00:36 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     SANETO Takanori
>Release:        5.2-CURRENT
>Organization:
an individual
>Environment:
FreeBSD muse.sanewo.ddo.jp 5.2-CURRENT FreeBSD 5.2-CURRENT #321: Mon Aug 16 23:41:11 JST 2004     root at muse.sanewo.ddo.jp:/export/usr/obj/usr/src/sys/MUSE  i386
>Description:
      When named is running with options (e.g. "/usr/sbin/named -u bind"), "ndc restart" cause core dump.

>How-To-Repeat:
      as described above.
>Fix:
      Following patch to ndc.c should fix this. I confirmed that ISC bind-8.4.4 has this fix in it.

retrieving revision 1.1.1.7
diff -u -r1.1.1.7 ndc.c
--- contrib/bind/bin/ndc/ndc.c  17 Jun 2003 08:24:06 -0000      1.1.1.7
+++ contrib/bind/bin/ndc/ndc.c  25 Aug 2004 15:21:23 -0000
@@ -353,6 +353,7 @@
                *tp++ = c;
                cp++;
        }
+       *tp = '\0';
 }

 static int

>Release-Note:
>Audit-Trail:
>Unformatted: