bin/70336: telnetd always exits with value 1

[David S. Wang]

>Number:         70336
>Category:       bin
>Synopsis:       telnetd always exits with value 1
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 12 01:20:23 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     David S. Wang
>Release:        4.7-RELEASE
>Organization:
Juniper Networks
>Environment:
FreeBSD blah.juniper.net 4.7-RELEASE FreeBSD 4.7-RELEASE #0: Thu Nov  6 00:57:58 GMT 2003     dsw at blah.juniper.net:/usr/src/sys/compile/GENERIC-DDB  i386

>Description:
telnetd seems to always exit with a status of 1.  It seems to be hardcoded into telnetd's cleanup() function, even for normal exits.  This will cause inetd to always print a message to the syslog when a maximum number of children is configured for telnetd (see bin/70335 for details).  That seems to be unnecessary pollution of the syslog to me, and is also unnecessarily alarming in the case that telnetd exits normally.  Note that (most?) other daemons do not exit with a status of 1.
>How-To-Repeat:
Configure inetd.conf to have a finite maximum number of children for telnetd.  telnet into the box, then logout normally.  Look at the syslog.
>Fix:
Perhaps all the _exit(1) calls in cleanup() should be changed to _exit(0)?
>Release-Note:
>Audit-Trail:
>Unformatted: