kern/65402: patch: fflush() should not return error on readonly files

Radim Kolar hsn at netmag.cz
Fri Apr 16 10:20:03 PDT 2004


The following reply was made to PR kern/65402; it has been noted by GNATS.

From: Radim Kolar <hsn at netmag.cz>
To: Colin Percival <colin.percival at wadham.ox.ac.uk>
Cc: freebsd-gnats-submit at FreeBSD.org
Subject: Re: kern/65402: patch: fflush() should not return error on readonly files
Date: Fri, 16 Apr 2004 18:47:32 +0200

 > FreeBSD's behavior here is consequently correct; any behaviour would be
 > correct.  Programs which rely upon fflush() not returning an error when
 > passed a file which is opened read-only are broken, and should be fixed.
 I agree with you that my problem application rely upon nonportable behaviour.
 This is not reason for not including this patch.
 
 My points for including this patch are:
 
 1) do not breaks ISO standard
 2) do not breaks existing apps
 3) improve FreeBSD source code compatibility with other OSes, because these OSes are doing the same.
 4) fixes problem with my application, which is large (10MB) and difficult to fix.
 
 In summary: This patch will make things better, not worse. I do not know
 about negative side-effects.
 
 Radim


More information about the freebsd-bugs mailing list