bin/57401: amd sets wrong permissions on mount point for msdosfs

Andre Albsmeier andre.albsmeier at siemens.com
Tue Sep 30 04:10:22 PDT 2003


>Number:         57401
>Category:       bin
>Synopsis:       amd sets wrong permissions on mount point for msdosfs
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 30 04:10:20 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Andre Albsmeier
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
>Environment:

System: FreeBSD 4.8-STABLE

>Description:

In august, the -M mask option for msdosfs was added:

http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/msdosfs/Attic/msdosfsmount.h

amd doesn't know about the new mode_t dirmask which results
in the mountpoint having wrong permissions:

d---------  1 root  wheel  arch 7168 31 Dez  1979 /A/floppy/

>How-To-Repeat:

Configure amd to mount a msdos fs automatically and check
the permissions of the resulting mountpoint.

>Fix:

Quick and dirty:

--- contrib/amd/amd/ops_pcfs.c.ORI	Tue Sep 30 12:29:49 2003
+++ contrib/amd/amd/ops_pcfs.c	Tue Sep 30 12:54:14 2003
@@ -132,6 +132,7 @@
 
 #ifdef HAVE_FIELD_PCFS_ARGS_T_MASK
   pcfs_args.mask = 0777;	/* this may be the msdos file modes */
+  pcfs_args.dirmask = 0777;
 #endif /* HAVE_FIELD_PCFS_ARGS_T_MASK */
 
 #ifdef HAVE_FIELD_PCFS_ARGS_T_UID
>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list