kern/59211: System crashes when moving files from NWFS mounted

[Tim Robbins]

The following reply was made to PR kern/59211; it has been noted by GNATS.

From: Tim Robbins <tjr at freebsd.org>
To: Navoyenok Sergei <nasa at les.veco.ru>
Cc: bug-followup at freebsd.org
Subject: Re: kern/59211: System crashes when moving files from NWFS mounted
Date: Sat, 15 Nov 2003 21:38:40 +1100

 Can you try this patch (against RELENG_4)? This could be the same bug
 I fixed in smbfs_vnops.c 1.2.2.8. I haven't tested this since I don't
 have a working netware setup anymore.
 
 
 Index: nwfs_vnops.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/nwfs/Attic/nwfs_vnops.c,v
 retrieving revision 1.6.2.3
 diff -u -r1.6.2.3 nwfs_vnops.c
 --- nwfs_vnops.c	14 Mar 2001 11:26:59 -0000	1.6.2.3
 +++ nwfs_vnops.c	15 Nov 2003 10:27:49 -0000
 @@ -577,20 +577,22 @@
  		vput(tvp);
  	vrele(fdvp);
  	vrele(fvp);
 -	nwfs_attr_cacheremove(fdvp);
 -	nwfs_attr_cacheremove(tdvp);
 -	/*
 -	 * Need to get rid of old vnodes, because netware will change
 -	 * file id on rename
 -	 */
 -	vgone(fvp);
 -	if (tvp)
 -		vgone(tvp);
  	/*
  	 * Kludge: Map ENOENT => 0 assuming that it is a reply to a retry.
  	 */
  	if (error == ENOENT)
  		error = 0;
 +	if (error == 0) {
 +		nwfs_attr_cacheremove(fdvp);
 +		nwfs_attr_cacheremove(tdvp);
 +		/*
 +		 * Need to get rid of old vnodes, because netware will change
 +		 * file id on rename
 +		 */
 +		vgone(fvp);
 +		if (tvp)
 +			vgone(tvp);
 +	}
  	return (error);
  }