misc/58971: bug in libusbhid descriptor parser code.

[Alexander Nedotsukov]

>Number:         58971
>Category:       misc
>Synopsis:       bug in libusbhid descriptor parser code.
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 05 08:00:38 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Alexander Nedotsukov
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
>Environment:
System: FreeBSD bbnest.net 5.1-CURRENT FreeBSD 5.1-CURRENT #4: Mon Nov 3 16:13:21 JST 2003 bland at bbnest.net:/usr/obj/usr/src/sys/BBNEST i386


	
>Description:
According to specs "Report Size" is global item attribute therefore it should not be
cleared in hid_clear_local() wich supposed to clear local attributes only.
I have usb joystick wich report descriptor can not be properly parsed due this bug.
	
>How-To-Repeat:
	
>Fix:
Apply the patch attached.
	

--- libusbhid.patch begins here ---
Index: parse.c
===================================================================
RCS file: /home/ncvs/src/lib/libusbhid/parse.c,v
retrieving revision 1.8
diff -u -p -r1.8 parse.c
--- lib/libusbhid/parse.c	9 Apr 2003 01:52:48 -0000	1.8
+++ lib/libusbhid/parse.c	29 Oct 2003 05:51:12 -0000
@@ -86,7 +86,6 @@ hid_clear_local(hid_item_t *c)
 	c->string_minimum = 0;
 	c->string_maximum = 0;
 	c->set_delimiter = 0;
-	c->report_size = 0;
 }
 
 hid_data_t
--- libusbhid.patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: