bin/58850: Recent sysinstall changes wipes out rc.conf contents

[Anders Nordby]

>Number:         58850
>Category:       bin
>Synopsis:       Recent sysinstall changes wipes out rc.conf contents
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 02 16:30:18 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     anders at FreeBSD.org
>Release:        FreeBSD 4.9-RELEASE
>Organization:
Fluxpod Information eXchange
>Environment:

FreeBSD neta 4.9-RELEASE FreeBSD 4.9-RELEASE #0: Mon Oct 27 17:51:09 GMT 2003     root at freebsd-stable.sentex.ca:/usr/obj/usr/src/sys/GENERIC  i386

FreeBSD neta 5.1-RELEASE FreeBSD 5.1-RELEASE #0: Thu Jun  5 02:55:42 GMT 2003     root at wv1u.btc.adaptec.com:/usr/obj/usr/src/sys/GENERIC  i386

>Description:

Recent changes to sysinstall/config.c empties rc.conf in automated
installations.

>How-To-Repeat:

Set up a PXE automated install environment according to
http://www.freebsd.org/doc/en_US.ISO8859-1/articles/pxe/. Create a custom
package that adds data to /etc/rc.conf during installation using pkg-install.
Watch how rc.conf is emptied on install clients after throdes' changes to
config.c:

root at neta:~# cat /etc/rc.conf

# -- sysinstall generated deltas -- # Mon Nov  3 07:09:40 2003
# Created: Mon Nov  3 07:09:40 2003
# Enable network daemons for user convenience.
# Please make all changes to this file, not to /etc/defaults/rc.conf.
# This file now contains just the overrides from /etc/defaults/rc.conf.
hostname="booter"
ifconfig_fxp0="DHCP"
root at neta:~# 

Proof of concept: make that custom package add data to a temporary rc.conf file
instead, and of course, it is not emptied.

>Fix:

Re-do patch 1.156.2.34 -> 1.156.2.35 in src/release/sysinstall/config.c
(RELENG_4) and 1.210 -> 1.211 in src/usr.sbin/sysinstall/config.c (HEAD).

Work-around for your custom PXE post-installation fixup/rc.conf modification
package:

a) Create a temporary rc.conf script.
b) Create a /usr/local/etc/rc.d script that adds the contents of your temporary
rc.conf to the real one upon the next reboot, deletes itself and then does
another reboot.
>Release-Note:
>Audit-Trail:
>Unformatted: