kern/51825: QUIRK: OTi USB Flash Memory keyring

[Gregory Bond]

>Number:         51825
>Category:       kern
>Synopsis:       QUIRK: OTi USB Flash Memory keyring
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 05 19:40:05 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Gregory Bond
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
ITG Australia Limited
>Environment:
System: FreeBSD hellcat.itga.com.au 4.8-STABLE FreeBSD 4.8-STABLE #10: Tue May 6 12:05:40 EST 2003 toor at grollo.itga.com.au:/usr/obj/usr/src/sys/HELLCAT i386


>Description:

OTi USB Flash keyring needs NO_6_BYTE quirk.  Symptoms w/o the quirk
are long hang (> 30 sec) when trying to access, then an error when
attempting to read.
	da0: reading primary partition table: error reading fsbn 0

What clued me in was, sometimes, after several tries at reading, I got
the following message:
	(da0:umass-sim0:0:0:0): READ(6)/WRITE(6) not supported, increasing minimum_cmd_size to 10.

I don't know why the auto 10-byte fallback wasn't kicking in earlier
or more reliably; I'm happy to run some tests if anyone can tell me
what to do.

>How-To-Repeat:

Plug in an OTi USB flash disk.  Attempt to mount it.

umass0: USB Solid state disk, rev 1.10/1.00, addr 2
da0 at umass-sim0 bus 0 target 0 lun 0
da0: <OTi Flash Disk 1.11> Removable Direct Access SCSI-2 device 
da0: 650KB/s transfers
da0: 63MB (129024 512 byte sectors: 64H 32S/T 63C)
da0: reading primary partition table: error reading fsbn 0

hellcat# camcontrol inquiry da0
pass0: <OTi Flash Disk 1.11> Removable Direct Access SCSI-2 device 
pass0: Serial Number 
pass0: 650KB/s transfers 
hellcat# usbdevs -v
Controller /dev/usb0:
addr 1: self powered, config 1, UHCI root hub(0x0000), Intel(0x0000), rev 1.00
 port 1 powered
 port 2 powered
Controller /dev/usb1:
addr 1: self powered, config 1, UHCI root hub(0x0000), Intel(0x0000), rev 1.00
 port 1 addr 2: power 100 mA, config 1, Solid state disk(0x6803), USB(0x0ea0), rev 1.00
 port 2 powered
hellcat# 

>Fix:


--- OTi-quirk begins here ---
Index: sys/cam/scsi/scsi_da.c
===================================================================
RCS file: /usr/ncvs/src/sys/cam/scsi/scsi_da.c,v
retrieving revision 1.42.2.34
diff -u -r1.42.2.34 scsi_da.c
--- sys/cam/scsi/scsi_da.c	27 Apr 2003 20:05:11 -0000	1.42.2.34
+++ sys/cam/scsi/scsi_da.c	6 May 2003 02:05:24 -0000
@@ -426,6 +426,13 @@
 	},
 	{
 		/*
+		 * OTi USB Key-Storage
+		 */
+		{T_DIRECT, SIP_MEDIA_REMOVABLE, "OTi", "Flash Disk", "*"},
+		/*quirks*/ DA_Q_NO_6_BYTE
+	},
+	{
+		/*
 		 * Lexar Media Jumpdrive
 		 * PR: kern/47006
 		 */
--- OTi-quirk ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: