misc/51955: pccard_ether textual errors (fwd)

[Maxim Konovalov]

The following reply was made to PR misc/51955; it has been noted by GNATS.

From: Maxim Konovalov <maxim at macomnet.ru>
To: bug-followup at freebsd.org
Cc:  
Subject: Re: misc/51955: pccard_ether textual errors (fwd)
Date: Sun, 8 Jun 2003 19:23:29 +0400 (MSD)

 Add to the audit trail.
 
 -- 
 Maxim Konovalov, maxim at macomnet.ru, maxim at FreeBSD.org
 
 ---------- Forwarded message ----------
 Date: Sun, 8 Jun 2003 17:05:42 +0200 (CEST)
 From: Xander <x+freebsd-gnats at surfnet.nl>
 To: Maxim Konovalov <maxim at macomnet.ru>
 Subject: Re: misc/51955: pccard_ether textual errors
 
 On Thu, 5 Jun 2003, Maxim Konovalov wrote:
 
 + On Thu, 8 May 2003, 10:20-0700, Xander wrote:
 + [...]
 + >  >Description:
 + >  The comment in pccard_ether (rev 1.29) at the top mentions a third argument
 + >  for 'ifconfig_option'. This argument appears to be unused in the script.
 +
 + It is used, actually.  Take a look at the line #87:
 +
 +                 # Do the primary ifconfig if specified
 +                 ifconfig ${interface} ${ifconfig_args} $*
 + -------------------------------------------------------^^
 
 Ah yes, I must have missed that one, wishful thinking probably, I needed
 the argument array ($*) for a quick'n dirty fix later on in the script.
 Since ume-san since then provided a much better solution for the problem I
 had (rcNG didn't setup IPv6 networking) that's not needed anymore.
 
 + >  -# example: pccard_ether ep0 start -link0
 + >  +# example: pccard_ether ep0 start
 +
 + Funny but ep(4) does not support link0 option.
 +
 + What do you think about following patch:
 +
 + Index: etc/pccard_ether
 + ===================================================================
 + RCS file: /home/ncvs/src/etc/pccard_ether,v
 + retrieving revision 1.30
 + diff -u -r1.30 pccard_ether
 + --- etc/pccard_ether	12 May 2003 11:36:49 -0000	1.30
 + +++ etc/pccard_ether	5 Jun 2003 08:28:12 -0000
 + @@ -4,7 +4,7 @@
 +  #
 +  # pccard_ether interfacename [start|stop] [ifconfig option]
 +  #
 + -# example: pccard_ether ep0 start -link0
 + +# example: pccard_ether fxp0 start -link0
 +  #
 +
 +  stop_dhcp() {
 + @@ -156,7 +156,7 @@
 +  		stop_dhcp
 +  		;;
 +  	*)
 + -		# Delelte static route if specified
 + +		# Delete static route if specified
 +  		eval ifx_routes=\$static_routes_${interface}
 +  		if [ -n "${ifx_routes}" ]; then
 +  			for i in ${ifx_routes}; do
 +
 + %%%
 
 Looks fine to me. Thanks for looking into this.
 -- 
 Xander