kern/52916: vinum causes panic after start/stop/... cycle, easy to reproduce

[Greg 'groggy' Lehey]

On Thursday,  5 June 2003 at 22:30:14 -0700, Greg 'groggy' Lehey wrote:
>
>  I'm guessing this has something to do with md devices.  Do you use
>  any?  I don't, and every 'vinum start' created one.  I've committed a
>  fix to vinum(8) (revision 1.31.2.6 of src/sbin/vinum/commands.c).
>  Please try it and tell me if it fixes the problem.  Here it is again
>  to save you cvsupping:
>
>  diff -w -u -r1.31.2.5 commands.c
>  --- commands.c  4 May 2002 05:04:14 -0000       1.31.2.5
>  +++ commands.c  6 Jun 2003 05:08:43 -0000
>  @@ -275,6 +275,10 @@
>       char reply[32];
>       int error;
>  =20
>  +    if (! isatty (STDIN_FILENO)) {
>  +       fprintf (stderr, "Please enter this command from a tty device\n");
>  +       return;
>  +    }
>       printf(" WARNING!  This command will completely wipe out your vinum co=
>  nfiguration.\n"
>          " All data will be lost.  If you really want to do this, enter the =
>  text\n\n"
>          " NO FUTURE\n"

Ugh.  Did GNATS do that?

Anyway, don't bother.  I can now reproduce the problem more easily :-(

Greg
--
See complete headers for address and phone numbers
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-bugs/attachments/20030606/16c7a865/attachment.bin