misc/51955: pccard_ether textual errors

Maxim Konovalov maxim at macomnet.ru
Thu Jun 5 01:40:14 PDT 2003


The following reply was made to PR misc/51955; it has been noted by GNATS.

From: Maxim Konovalov <maxim at macomnet.ru>
To: Xander <x+freebsd-gnats at surfnet.nl>
Cc: bug-followup at freebsd.org
Subject: Re: misc/51955: pccard_ether textual errors
Date: Thu, 5 Jun 2003 12:32:26 +0400 (MSD)

 On Thu, 8 May 2003, 10:20-0700, Xander wrote:
 [...]
 >  >Description:
 >  The comment in pccard_ether (rev 1.29) at the top mentions a third argument
 >  for 'ifconfig_option'. This argument appears to be unused in the script.
 
 It is used, actually.  Take a look at the line #87:
 
                 # Do the primary ifconfig if specified
                 ifconfig ${interface} ${ifconfig_args} $*
 -------------------------------------------------------^^
 
 >  There's also a typo (delelte) elsewhere in the script.
 >  >How-To-Repeat:
 >
 >  >Fix:
 >  The following patch removes the remarks about the ifconfig_option and fixes
 >  the typo. Whether removing the ifconfig_option explanation is the best way
 >  to go is left to the maintainer of course.
 >
 >  --- pccard_ether.rev1.29	Tue May  6 13:38:48 2003
 >  +++ pccard_ether	Thu May  8 09:31:31 2003
 >  @@ -2,9 +2,9 @@
 >   #
 >   # $FreeBSD: src/etc/pccard_ether,v 1.29 2003/05/05 19:06:46 ume Exp $
 >   #
 >  -# pccard_ether interfacename [start|stop] [ifconfig option]
 >  +# pccard_ether interfacename [start|stop]
 >   #
 >  -# example: pccard_ether ep0 start -link0
 >  +# example: pccard_ether ep0 start
 
 Funny but ep(4) does not support link0 option.
 
 What do you think about following patch:
 
 Index: etc/pccard_ether
 ===================================================================
 RCS file: /home/ncvs/src/etc/pccard_ether,v
 retrieving revision 1.30
 diff -u -r1.30 pccard_ether
 --- etc/pccard_ether	12 May 2003 11:36:49 -0000	1.30
 +++ etc/pccard_ether	5 Jun 2003 08:28:12 -0000
 @@ -4,7 +4,7 @@
  #
  # pccard_ether interfacename [start|stop] [ifconfig option]
  #
 -# example: pccard_ether ep0 start -link0
 +# example: pccard_ether fxp0 start -link0
  #
 
  stop_dhcp() {
 @@ -156,7 +156,7 @@
  		stop_dhcp
  		;;
  	*)
 -		# Delelte static route if specified
 +		# Delete static route if specified
  		eval ifx_routes=\$static_routes_${interface}
  		if [ -n "${ifx_routes}" ]; then
  			for i in ${ifx_routes}; do
 
 %%%
 
 -- 
 Maxim Konovalov, maxim at macomnet.ru, maxim at FreeBSD.org


More information about the freebsd-bugs mailing list