kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever

[Gleb Smirnoff]

The following reply was made to PR kern/47920; it has been noted by GNATS.

From: Gleb Smirnoff <glebius at cell.sick.ru>
To: Yar Tikhiy <yar at FreeBSD.ORG>
Cc: FreeBSD-gnats-submit at FreeBSD.ORG
Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever
Date: Fri, 19 Dec 2003 12:49:55 +0300

 On Thu, Dec 18, 2003 at 08:22:04PM +0300, Yar Tikhiy wrote:
 Y> Thanks!  By the way, don't you think that the default value for the
 Y> sysctl controlling pppoe mode should be -1?  I've just read this PR
 Y> once more and realized that the current default of 0 is *really dangerous*
 Y> because a spurious non-standard PPPoE frame can plague an entire network!
 
 You are absolutely right. This is a real DoS condition. I have mentioned this
 in freebsd-net, but nobody payed attention. As well as nobody payed attention
 to PR itself. May be it was ignored because of its type: "change-request", not
 "sw-bug" (originator's fault).
 
 When I submitted the patch, I wanted it to be commited as soon as possible,
 so I didn't change default behavior. AFAIK, patches that do change default
 behavior are applied more slowly. Set me right, if I mistake.
 
 So, I absolutely agree that default value should be -1. :)
 
 -- 
 Totus tuus, Glebius.
 GLEBIUS-RIPN GLEB-RIPE