kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever

[Yar Tikhiy]

The following reply was made to PR kern/47920; it has been noted by GNATS.

From: Yar Tikhiy <yar at FreeBSD.ORG>
To: Gleb Smirnoff <glebius at cell.sick.ru>
Cc: FreeBSD-gnats-submit at FreeBSD.ORG
Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever
Date: Thu, 18 Dec 2003 20:22:04 +0300

 Mime-Version: 1.0
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 In-Reply-To: <20031218100848.GA67923 at cell.sick.ru>
 User-Agent: Mutt/1.5.3i
 
 On Thu, Dec 18, 2003 at 01:08:48PM +0300, Gleb Smirnoff wrote:
 > On Wed, Dec 17, 2003 at 08:42:34PM +0300, Yar Tikhiy wrote:
 > Y> Would you mind testing the below version of your patch, revised.
 > Y> Please pay attention to its points:
 > Y> a) sanity check values passed through sysctl;
 > Y> b) avoid double setting nonstandard mode;
 > Y> c) format source according to style(9);
 > Y> d) initialize pppoe_mode for clarity since it's no longer
 > Y>    just a boolean trigger.
 > 
 > I have tested it on STABLE. It works OK. I have also asked PR's
 > originator to test it.
 
 Thanks!  By the way, don't you think that the default value for the
 sysctl controlling pppoe mode should be -1?  I've just read this PR
 once more and realized that the current default of 0 is *really dangerous*
 because a spurious non-standard PPPoE frame can plague an entire network!
 
 -- 
 Yar