kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever

Gleb Smirnoff glebius at cell.sick.ru
Thu Dec 18 02:10:20 PST 2003


The following reply was made to PR kern/47920; it has been noted by GNATS.

From: Gleb Smirnoff <glebius at cell.sick.ru>
To: Yar Tikhiy <yar at FreeBSD.ORG>
Cc: FreeBSD-gnats-submit at FreeBSD.ORG
Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever
Date: Thu, 18 Dec 2003 13:08:48 +0300

 On Wed, Dec 17, 2003 at 08:42:34PM +0300, Yar Tikhiy wrote:
 Y> Would you mind testing the below version of your patch, revised.
 Y> Please pay attention to its points:
 Y> a) sanity check values passed through sysctl;
 Y> b) avoid double setting nonstandard mode;
 Y> c) format source according to style(9);
 Y> d) initialize pppoe_mode for clarity since it's no longer
 Y>    just a boolean trigger.
 
 I have tested it on STABLE. It works OK. I have also asked PR's
 originator to test it.
 
 -- 
 Totus tuus, Glebius.
 GLEBIUS-RIPN GLEB-RIPE


More information about the freebsd-bugs mailing list