bin/55124: [PATCH] request total incorrectly reported by vmstat(8)

[Bruce M Simpson]

The following reply was made to PR bin/55124; it has been noted by GNATS.

From: Bruce M Simpson <bms at spc.org>
To: David Schultz <das at FreeBSD.ORG>
Cc: FreeBSD-gnats-submit at FreeBSD.ORG
Subject: Re: bin/55124: [PATCH] request total incorrectly reported by vmstat(8)
Date: Wed, 6 Aug 2003 18:26:29 +0100

 On Mon, Aug 04, 2003 at 11:23:23PM -0700, David Schultz wrote:
 > > 	Under RELENG_4, the running total of requests for each subsystem
 > > 	client of the vm (vmstat -m) is incorrectly reported due to the use
 > > 	of a signed (vs unsigned) integer.
 > [...]
 > > -	long totuse = 0, totfree = 0, totreq = 0;
 > > +	long totuse = 0, totfree = 0;
 > > +	unsigned long totreq = 0;
 > 
 > This only buys you a factor of 2, then it overflows again.  totreq
 > should be a uint64_t like the ks_calls values it's accumulating.
 
 Agreed, it is a purely symptomatic fix for the user's problem...
 
 PS Are you stalking my PRs or something? :-) If so, please look at
 the conf/* ones if you have time...
 
 BMS