bin/55124: [PATCH] request total incorrectly reported by vmstat(8)

David Schultz das at FreeBSD.ORG
Mon Aug 4 23:30:18 PDT 2003


The following reply was made to PR bin/55124; it has been noted by GNATS.

From: David Schultz <das at FreeBSD.ORG>
To: Bruce M Simpson <bms at spc.org>
Cc: FreeBSD-gnats-submit at FreeBSD.ORG
Subject: Re: bin/55124: [PATCH] request total incorrectly reported by vmstat(8)
Date: Mon, 4 Aug 2003 23:23:23 -0700

 > 	Under RELENG_4, the running total of requests for each subsystem
 > 	client of the vm (vmstat -m) is incorrectly reported due to the use
 > 	of a signed (vs unsigned) integer.
 [...]
 > -	long totuse = 0, totfree = 0, totreq = 0;
 > +	long totuse = 0, totfree = 0;
 > +	unsigned long totreq = 0;
 
 This only buys you a factor of 2, then it overflows again.  totreq
 should be a uint64_t like the ks_calls values it's accumulating.


More information about the freebsd-bugs mailing list