bluetooth.h, c++ include error

[Masoom Shaikh]

On Mon, Oct 5, 2009 at 5:26 PM, Iain Hibbert <plunky at rya-online.net> wrote:

> On Mon, 5 Oct 2009, Masoom Shaikh wrote:
>
> > what i am requesting is just variable name change ;-) my tree is at
> > revision 197571, thus the patch i am presenting is also generated
> > against it reject this if you want patch against latest revision
> >
> > renamed second argument of bt_devfilter() from 'new' to 'dfnew'. df for
> > device filter to maintain uniformity renamed third argument from 'old'
> > to 'dfold'.
>
> style(9) mentions that for kernel include files exposed to userland
> (technically, this is always in userland but perhaps the same rules apply)
> the prototype tag arguments should be made safe, eg starting with a _
> perhaps for much this reason..
>
> so, my suggestion would be to use _new and _old etc..
>
> iain
>
> (or, just don't use them, they are not especially required :)
>
>
>
>
> so this shall work
i just renamed bt_devfilter() variable names, because it was the one which
caused trouble
will someone commit this ?

Index: bluetooth.h
===================================================================
--- bluetooth.h    (revision 197804)
+++ bluetooth.h    (working copy)
@@ -163,8 +163,8 @@
 int        bt_devsend (int s, uint16_t opcode, void *param, size_t plen);
 ssize_t        bt_devrecv (int s, void *buf, size_t size, time_t to);
 int        bt_devreq  (int s, struct bt_devreq *r, time_t to);
-int        bt_devfilter(int s, struct bt_devfilter const *new,
-                 struct bt_devfilter *old);
+int        bt_devfilter(int s, struct bt_devfilter const *_new,
+                 struct bt_devfilter *_old);
 void        bt_devfilter_pkt_set(struct bt_devfilter *filter, uint8_t
type);
 void        bt_devfilter_pkt_clr(struct bt_devfilter *filter, uint8_t
type);
 int        bt_devfilter_pkt_tst(struct bt_devfilter const *filter, uint8_t
type);