Kernel build failure on rpi2 at 344613

[Kyle Evans]

On Tue, Feb 26, 2019 at 11:06 PM Ian Lepore <ian at freebsd.org> wrote:
>
> On Tue, 2019-02-26 at 19:55 -0800, bob prohaska wrote:
> > In trying to make world and kernel on RPI2 at r344613 buildworld ran
> > to
> > completion, but buildkernel stopped wtih
> > --- machdep_boot.o ---
> > /usr/src/sys/arm/arm/machdep_boot.c:170:34: error: too few arguments
> > to function call, single argument 'cmdline' was not specified
> >         boothowto |= boot_parse_cmdline();
> >                      ~~~~~~~~~~~~~~~~~~ ^
> > /usr/src/sys/sys/boot.h:37:1: note: 'boot_parse_cmdline' declared
> > here
> > int boot_parse_cmdline(char *cmdline);
> > ^
> > 1 error generated.
> > *** [machdep_boot.o] Error code 1
> >
> > make[2]: stopped in /usr/obj/usr/src/sys/RPI2
> >
> > The machine is running
> > FreeBSD www.zefox.com 11.2-STABLE FreeBSD 11.2-STABLE #0 r343555: Wed
> > Jan 30 04:55:19 PST 2019     bob at www.zefox.com:/usr/obj/usr/src/sys/R
> > PI2  arm
> >
> > Any idea how to get past this impediment?
> >
> > Thanks for reading,
> >
> > bob prohaska
> >
>
> Fix should be committed soon; to get moving right away, apply this
> patch:
>
> https://svnweb.freebsd.org/base/head/sys/arm/arm/machdep_boot.c?r1=336244&r2=336262&view=patch
>

I clearly  failed to catch it, but I'm also trying to decide why
Jenkins' stable/11 job didn't catch it... machdep_boot is standard
arm*, but the build didn't skip a beat. CC'ing lwhsu@/freebsd-testing@
because that seems like it might be indicative of a slightly larger
problem.

In either case, thanks for the pointer! MFC is getting committed momentarily.