One last item: CNS1102 support removal

[Warner Losh]

On Thu, Jul 19, 2018 at 3:25 AM, Andrew Turner <andrew at fubar.geek.nz> wrote:

>
> > On 18 Jul 2018, at 23:44, Mori Hiroki <yamori813 at yahoo.co.jp> wrote:
> >
> > Hi
> >
> >
> > ----- Original Message -----
> >> From: Warner Losh <imp at bsdimp.com>
> >> To: Mori Hiroki <yamori813 at yahoo.co.jp>
> >> Cc: "freebsd-arm at freebsd.org" <freebsd-arm at freebsd.org>
> >> Date: 2018/7/19, Thu 03:01
> >> Subject: Re: One last item: CNS1102 support removal
> >>
> >>
> >>
> >>
> >>
> >>
> >> On Wed, Jul 18, 2018 at 11:41 AM, Mori Hiroki <yamori813 at yahoo.co.jp>
> wrote:
> >>
> >> Hi
> >>>
> >>>
> >>> sys/arm/ralink is work fine. Please do not remove this.
> >>
> >>
> >> OK. Do you have a kernel config file we can commit to the tree? I don't
> even know if it compiles, apart from your dmesg posts. I wasn't sure based
> on your email, so I thought I'd ask for clarification.
> >
> > This is kernel configure file.
> >
> > https://svnweb.freebsd.org/base/head/sys/arm/conf/RT1310?view=markup
>
> That config file fails to build. It's marked with NO_UNIVERSE so it won’t
> be tested by the universe of tinderbox targets.
>

It's missing the machine directive, the cpu directive, the hints file it
specifies isn't there and the fv and rt1310gpio devices specified in it
aren't found. Fixing all that gives:

--- rt1310_intc.o ---
/usr/home/imp/git/head/sys/arm/ralink/rt1310_intc.c:404:7: error: implicit
declaration of function 'fdt_is_compatible' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
        if (!fdt_is_compatible(node, "lpc,pic"))
             ^
/usr/home/imp/git/head/sys/arm/ralink/rt1310_intc.c:404:7: note: did you
mean 'fdt_find_compatible'?
/usr/home/imp/git/head/sys/dev/fdt/fdt_common.h:85:11: note:
'fdt_find_compatible' declared here
phandle_t fdt_find_compatible(phandle_t, const char *, int);
          ^
/usr/home/imp/git/head/sys/arm/ralink/rt1310_intc.c:404:7: error: this
function declaration is not a prototype [-Werror,-Wstrict-prototypes]
        if (!fdt_is_compatible(node, "lpc,pic"))
             ^
2 errors generated.
*** [rt1310_intc.o] Error code 1

make[2]: stopped in
/usr/home/imp/obj/usr/home/imp/git/head/arm.arm/sys/RT1310

Warner