[Bug 210705] freebsd/sys/arm/mv/mv_common.c:2252]: (style) Suspicious condition

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210705

            Bug ID: 210705
           Summary: freebsd/sys/arm/mv/mv_common.c:2252]: (style)
                    Suspicious condition
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: arm
          Assignee: freebsd-arm at FreeBSD.org
          Reporter: dcb314 at hotmail.com

freebsd/sys/arm/mv/mv_common.c:2252]: (style) Suspicious condition (assignment
+ comparison); Clarify expression with parentheses.

Source code is

        if (fdt_addrsize_cells(node, &addr_cells, &size_cells) == 0 &&
            (par_addr_cells = fdt_parent_addr_cells(node) <= 2)) {

Maybe better code

        if (fdt_addrsize_cells(node, &addr_cells, &size_cells) == 0 &&
            (par_addr_cells = fdt_parent_addr_cells(node)) <= 2) {

-- 
You are receiving this mail because:
You are the assignee for the bug.