INTRNG (Was: svn commit: r301453....)

[Nathan Whitehorn]

On 08/06/16 07:30, Michal Meloun wrote:

[snip]
> I have prepared working patch (it's not full, but it works  on Tegra),
> https://github.com/strejda/tegra/commit/2cf72e248877fb917c4fc618bcb6e46b7c1058a4
> can you, please, take look on it?
>
> Also, please, take in account:
> - we have, currently, 20+  interrupt controllers converted to new INTRNG
> PIC API.
> - universal format of  interrupt resources is generic part of this API.
> - I'm not ready to commit any PIC API change together with above patch -
> i hope that this is understandable.

One other non-urgent question about PCI code:

There's a new function ofw_bus_msimap() that does not seem to implement 
any particular part of any real binding standard. There's a .txt file in 
the device-tree repo, but many (most?, all?) PCI bridges don't seem to 
implement MSI that way. This is out-of-scope for the immediate 
discussion, but it would be good to fix later. If there are indeed only 
a handful of bridges that do MSI that way, it should probably be moved 
into the PCI bridge drivers that do use it.

Similarly, dev/pci/pci_host_generic.c isn't actually generic and is 
instead a driver for some particular ARM bridges. It should be moved at 
some point under sys/arm. Most of the code in it also duplicates 
dev/ofw/ofwpci.c (but with some added bugs in handling the "ranges" 
property).

> also,
> "we must be able to add new interrupt type as simple as possible" rule
> is very important for me. Adding new table (with implementation), one
> bus method and one PIC method for each new type is not *simple*.
>
> In any case, can we concentrate to above patch first? I'm ready to
> finish it in next few hours, then put it to phabricator for real review.
>

Have you had a chance to finish this? Is there a way I can help? I think 
non-MSI PCI interrupts are currently broken on ARM and it would be great 
to get that fixed before 11.0.
-Nathan