[Differential] [Commented On] D2377: Introduce ARM GICv3 support

Mon May 11 13:19:51 UTC 2015

zbb added inline comments.

INLINE COMMENTS
  sys/arm64/arm64/gic_v3_fdt.c:81 I don't get it. What do you mean "parent bus for these"? When you did your first reviews on GitHub you asked for separate FDT-specific attachment for GICv3. Now we have some need for separate bus for GICv3? Can you point me some other example of such bus among other PIC controllers in FreeBSD?
  sys/arm64/arm64/gic_v3_fdt.c:155 I don't understand what is your intention here. Can you point me to the example in the other PIC driver?
  sys/arm64/include/armreg.h:112 To avoid another ping-pong:
  1023 is a spurious interrupt ID that is described in GICv3 docs and is being read from ICC_IAR1_EL1 register.

  Do you ask because:
  1) you want it moved/redefined somewhere else?
  2) for other reason (explain)

REVISION DETAIL
  https://reviews.freebsd.org/D2377

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, emaste, ian, imp, andrew, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm