[Differential] [Commented On] D2377: Introduce ARM GICv3 support

andrew (Andrew Turner) phabric-noreply at FreeBSD.org
Wed May 6 09:33:52 UTC 2015


andrew added inline comments.

INLINE COMMENTS
  sys/arm64/arm64/gic_v3.c:509 I think it comes from `Do not use ! for tests unless it is a boolean,...`.
  sys/arm64/arm64/gic_v3_reg.h:108 It appears to be for the ICC_SRE register, however it's not in armreg.h, and there is no comment pointing this out to help find the details in the documentation.

REVISION DETAIL
  https://reviews.freebsd.org/D2377

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, emaste, ian, imp, andrew, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm


More information about the freebsd-arm mailing list