[Differential] [Commented On] D2018: Introduce Annapurna Labs AHCI support

[mav (Alexnder Motin)]

mav added inline comments.

INLINE COMMENTS
  sys/dev/ahci/ahci.c:150-153 AHCI specification defines this register as read-only. It tells nothing about "restoring" this register. I don't like idea of writing to read-only registers.
  sys/dev/ahci/ahci.c:199-201 According to specification, this is something that platform/BIOS must set. I know that Linux sets it always, but I believe that this is spec violation. If there is some BROKEN hardware that require it to be set by the driver, I can accept hardware-specific quirk or some tunable, but not global.

REVISION DETAIL
  https://reviews.freebsd.org/D2018

To: zbb, mav, imp, smh
Cc: freebsd-arm