[Differential] [Changed Subscribers] D3094: Fix ARMv8 KSTACK_PAGES issue
kib (Konstantin Belousov)
phabric-noreply at FreeBSD.org
Wed Jul 15 12:43:33 UTC 2015
kib added a subscriber: kib.
INLINE COMMENTS
sys/arm64/include/param.h:98 IMO moving KSTACK_PAGES to GENERIC is not right, since you require now that any kernel config has the statement for KSTACK_PAGES. The knob is not considered something that average user should tune.
The more proper solution is to use kstack_pages variable instead of the preprocessing symbol. This might even allow to set the default kernel stack size using tunable. The tricky place is the td0 stack allocation in locore. E.g., on i386 it looks easy to use kstack_pages for the stack size, but it is not possible to fetch the value from the kernel environment so early.
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D3094
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: wma_semihalf.com, emaste, zbb, andrew
Cc: kib, imp, andrew, freebsd-arm-list, emaste
More information about the freebsd-arm
mailing list