[Differential] [Changed Subscribers] D1967: Attempt to make libcxxrt's dwarf_eh work with strict alignment

imp (Warner Losh) phabric-noreply at FreeBSD.org
Wed Feb 25 22:45:12 UTC 2015


imp added a subscriber: imp.
imp added a comment.

I'd just do a memcpy version of the read routines. All this #ifdef junk is insane. It will do the right thing every time.

INLINE COMMENTS
  contrib/libcxxrt/dwarf_eh.h:154-163 uint16_t res;
  memcpy(&res, reinterpret_cast<void *>(*data), sizeof(uint16_)t);
  
  would be better.
  contrib/libcxxrt/dwarf_eh.h:176-188 see above for less insane code.
  contrib/libcxxrt/dwarf_eh.h:200-221 see above for less insane code.

REVISION DETAIL
  https://reviews.freebsd.org/D1967

To: dim, andrew, bapt, ian, theraven
Cc: imp, emaste, freebsd-arm


More information about the freebsd-arm mailing list