[Differential] [Commented On] D1833: Add memory barriers to buf_ring
meloun-miracle-cz (Michal Meloun)
phabric-noreply at FreeBSD.org
Sun Feb 22 09:20:53 UTC 2015
meloun-miracle-cz added a comment.
First of all, I was wrong in the behavior of atomic operations on ARM. After yesterday’s long session on IRC with Ian and Andy, we concluded that pure (non atomic) store affects(clears) state of exclusive monitor. So our implementation of atomics is fine on ARM. I apologize for my mistake, and, please, ignore everything about atomic_cmpset() in my previous message.
Back to your first question. I thought it only as a technical note (because misordered read occurs on br_ring[]). So, i'm fine with proposed patch.
And again, sorry for noise. I certainly did not intend to be “destructive”.
REVISION DETAIL
https://reviews.freebsd.org/D1833
To: zbb, kmacy, rpaulo, imp
Cc: meloun-miracle-cz, onwahe-gmail-com, andrew, ian, adrian, freebsd-arm
More information about the freebsd-arm
mailing list