[Differential] [Changed Subscribers] D1912: Fix endianness on FDT read in ARM GIC

onwahe-gmail-com (Svatopluk Kraus) phabric-noreply at FreeBSD.org
Fri Feb 20 13:12:28 UTC 2015


onwahe-gmail-com added a subscriber: onwahe-gmail-com.
onwahe-gmail-com added a comment.

In fact, the opposite is correct. In present, the arguments passed to function are already in suitable format. So, all fdt32_to_cpu() calls should be removed. I remembered some debate with Michal about that that only consumer knows what kind of data come to him, so decoding should be done on his side entirely. However, in current tree, the data are decoded in ofw_bus_intr_to_rl().

REVISION DETAIL
  https://reviews.freebsd.org/D1912

To: zbb, imp, andrew
Cc: onwahe-gmail-com, freebsd-arm


More information about the freebsd-arm mailing list