[crochet, wandboard] newfs_msdos: 12762 clusters too few clusters for FAT32, need 65525

[Boris Samorodov]

Hi Tom, All,

21.05.2014 19:43, Tom Everett пишет:

> Hello Boris.  I believe that is my bug you've found.  are you planning to
> submit a patch?

Sure:
-----
--- board/Wandboard/setup.sh.orig       2014-05-21 20:49:02.907014085 +0400
+++ board/Wandboard/setup.sh    2014-05-21 20:49:17.266011383 +0400
@@ -13,7 +13,7 @@
 wandboard_partition_image ( ) {
     disk_partition_mbr
     wandboard_uboot_install
-    disk_fat_create 50m 32 16384
+    disk_fat_create 50m 16 16384
     disk_ufs_create
 }
-----

Thanks!

> 
> 
> On Wed, May 21, 2014 at 4:40 AM, Boris Samorodov <bsam at passap.ru> wrote:
> 
>> Hi All,
>>
>> Using crochet to create an image for wandboard:
>> -----
>> [...]
>> Creating a 3900MB raw disk image in:
>>
>> /home/bsam/crochet-freebsd-master/work/FreeBSD-armv6-11.0-IMX6-r266491.img
>> Partitioning the raw disk image at среда, 21 мая 2014 г. 13:24:15 (SAMT)
>> gpart create -s MBR md1
>> md1 created
>> Installing U-Boot to /dev/md1
>> 582+0 records in
>> 582+0 records out
>> 297984 bytes transferred in 6.019639 secs (49502 bytes/sec)
>> Creating a 50m FAT partition at среда, 21 мая 2014 г. 13:24:21 (SAMT)
>> with start block 16384 and label BOOT
>> active set on md1s1
>> newfs_msdos: 12762 clusters too few clusters for FAT32, need 65525
>> -----
>>
>> The line from board/Wandboard/setup.sh "disk_fat_create 50m 32 16384"
>> uses FA32 and fails. After I change the line to "disk_fat_create 50m 16
>> 16384" (use FAT16) the command succeeds.
>>
>> This change seems to be in par with code at lib/disk.sh:
>> -----
>>     _FAT_TYPE=$2
>>     if [ -z "${_FAT_TYPE}" -o \( "${_FAT_TYPE}" = "-1" \) ]; then
>>         case $1 in
>>             *k | [1-9]m | 1[0-6]m) _FAT_TYPE=12
>>                 ;;
>>             *m) _FAT_TYPE=16
>>                 ;;
>>             *g) _FAT_TYPE=32
>>                 ;;
>>         esac
>> -----
>>
>> I.e. if a partition is set in megabytes, use FAT16.

-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve