OpenRD-Client/Ultimate support

[Kristof Provost]

On 2010-06-21 14:46:02 (+0200), Rafal Jaworowski <raj at semihalf.com> wrote:
> 
> On 2010-06-21, at 14:32, Kristof Provost wrote:
> 
> > On 2010-06-21 14:08:47 (+0200), Rafal Jaworowski <raj at semihalf.com> wrote:
> >> 
> >> On 2010-06-20, at 15:03, Norikatsu Shigemura wrote:
> >>> 	2. Change how to set PHY numbers.
> >>> 	   Suggested by: Kristof Provost
> >> 
> >> Please elaborate on what is being fixed with PHY numbering here.
> >> 
> > The driver simply didn't work if there were multiple ethernet ports.
> > It always programmed the address of the first available PHY for both.
> 
> I thought we tested with two ports on MV-78100, but maybe something didn't make it to the SVN tree or got mismerged. So what is the part of the patch that fixes this problem, is it this hunk?
> 
Perhaps it did work on the MV-78100 because the bootloader initialised
the MGE_REG_PHYDEV. Before r201198 the driver simply didn't set that
register so the driver only worked if the bootloader did that for us.

> @@ -716,8 +718,7 @@
>         sc->mii = device_get_softc(sc->miibus);
> 
>         /* Tell the MAC where to find the PHY so autoneg works */
> -       miisc = LIST_FIRST(&sc->mii->mii_phys);
> -       MGE_WRITE(sc, MGE_REG_PHYDEV, miisc->mii_phy);
> +       MGE_WRITE(sc, MGE_REG_PHYDEV, sc->phyaddr);
> 
>         /* Attach interrupt handlers */
>         for (i = 0; i < 2; ++i) {
> 

That's the one.

Regards,
Kristof