[patch] Compilation problems in sys/arm/arm/pmap.c when PMAP_DEBUG is defined.

[Olivier Houchard]

On Fri, Oct 02, 2009 at 03:56:00PM +0400, Stanislav Sedov wrote:
> On Fri, 02 Oct 2009 06:13:16 +0000
> Tom Judge <tom at tomjudge.com> mentioned:
> 
> > Hi,
> > 
> > I ran into some issues this evening while I was building some kernels 
> > with PMAP_DEBUG defined.
> > 
> > I have attached a patch that addresses the problems with the DPRINTF 
> > sections. (The first 2 hunks should probably be ignored).
> > 
> > However there are 2 warnings about unused functions when PMAP_INLINE is 
> > defined as "". I did not know what the correct fix for this was so I 
> > defined PMAP_INLINE to __inline even when PMAP_DEBUG was set, which 
> > seemed to hide the problem again.
> > 
> 
> Actually, these two functions with PMAP_INLINE prefixes are unused.  I
> believe we can drop them.
> 
> Olivier, what do you think about the following patch?
> 

Hi Stanislav,

Removing pmap_use_l1() is fine, but please just comment
pmap_dcache_wbinv_all() for now, and keep pmap_clean_page(), it's here to
remember we still write back/invalidate the whole cache in pmap_copy_page()
which is suboptimal.

Regards,

Olivier