Code review request: boards on AT91

[Stanislav Sedov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 25 Nov 2008 10:44:52 -0700 (MST)
"M. Warner Losh" <imp at bsdimp.com> mentioned:

> I'm trying a little experiment.  I'm moving the board support for the
> different sets of boards we support to their own file.  This is the
> first step in moving to supporting multiple boards more easily.
> There's a number of gross hacks to make this work now in at91 land,
> and I'd like to clean them up.  The mv port is much cleaner, but we
> still likely need some way to identify boards and get the right board
> support code called.  In Linux land, all ARM boot loaders are expected
> to pass in a machine type, which is used to do the multiplexing.
> Something similar in FreeBSD would be useful (and not just for ARM).
> 
> Eventually, I'd like to see more common code between the different arm
> variants.  This will ease porting efforts as well as make the code
> more robust.

I think we could pass the board type via a special kenv variable
for now. I think it will work fine and applicable to all supported
architectures. We could probably reuse board type constants that Linux
kernel uses.

> 
> If anybody wants me to write up where I'm going with this, or answer
> any question, please feel free to ask.  Also, comments would be nice.
> 
> Warner
> 

The code looks OK to me. I have only one question: why you have added
a commented out AT91_BOARD_KB920X option to the default kernel config?
Is it just a leftover?

- -- 
Stanislav Sedov
ST4096-RIPE
-----BEGIN PGP SIGNATURE-----

iEYEARECAAYFAkksQs0ACgkQK/VZk+smlYFntwCfbHv6JJmTjzI6GL5Ra1k4nA2a
nGAAn06uoskVCyZ2E5eFkTtQQ7eXnmz0
=xuFv
-----END PGP SIGNATURE-----