about src/lib/libkse/arch/arm/include/pthread_md.h

[Soeren Straarup]

On Sat, 2 Feb 2008 20:09:33 +0100
Olivier Houchard <mlfbsd at ci0.org> wrote:

> On Sat, Feb 02, 2008 at 06:54:49PM +0100, Soeren Straarup wrote:
> > On Sat, 2 Feb 2008 19:31:38 +0100
> > Olivier Houchard <mlfbsd at ci0.org> wrote:
> > 
> > > Hi Soeren,
> > > 
> > > On Sat, Feb 02, 2008 at 09:02:38AM +0100, Soeren Straarup wrote:
> > > > Hi,
> > > > 
> > > > Index: pthread_md.h
> > > > ===================================================================
> > > > RCS
> > > > file: /home/ncvs/src/lib/libkse/arch/arm/include/pthread_md.h,v
> > > > retrieving revision 1.9 diff -u -r1.9 pthread_md.h
> > > > --- pthread_md.h        9 Oct 2007 13:42:23 -0000       1.9
> > > > +++ pthread_md.h        1 Feb 2008 22:48:50 -0000
> > > > @@ -240,7 +240,7 @@
> > > >                 tcb->tcb_tmbx.tm_lwp = kcb->kcb_kmbx.km_lwp;
> > > >                 if (setmbox)
> > > >                         _thr_setcontext(mc,
> > > > (intptr_t)&tcb->tcb_tmbx,
> > > > -                               (intptr_t
> > > > *)&kcb->kcb_kmbx.km_curthread);
> > > > +                               (intptr_t
> > > > *)kcb->kcb_kmbx.km_curthread); else
> > > >                         _thr_setcontext(mc, 0, NULL);
> > > >         } else {
> > > > 
> > > > 
> > > > Is that change correct?
> > > > 
> > > 
> > > If I'm nor wrong, the original code is right, and that's what the
> > > other platforms seem to do so. Why do you think it should be
> > > changed ?
> > > 
> > 
> > Due to that if gcc is run with warnings set as errors it breaks.
> > 
> 
> We probably should do what other platforms do, and cast it to (void *)
> before (intptr_t *).
> Wanna commit it, or shall I ?

If you would then it would be in the right way (8
Hint i'm a ports committer

/Soeren

-- 
Soeren Straarup   | aka OZ2DAK aka Xride
FreeBSD committer | FreeBSD since 2.2.6-R
  If a program is not working right, then send a patch