[REVIEW] Re: Modernizing calendar(1) (was: svn commit: r365984 - head/usr.bin/calendar/calendars)

[Greg 'groggy' Lehey]

On Wednesday, 21 October 2020 at 19:48:31 -0600, Warner Losh wrote:
> On Wed, Oct 21, 2020, 4:03 AM Stefan Esser <se at freebsd.org> wrote:
>
>> Am 21.10.20 um 09:15 schrieb Stefan Esser:
>>> Am 21.10.20 um 03:23 schrieb Greg 'groggy' Lehey:
>>> [...]
>>>> That's the whole point.  Where do we draw the line?  Given that these
>>>> holidays interest more people outside the project than in, I'd think
>>>> that they should all go into the port.  And the whole idea of
>>>> alternative 3 is that the maintenance should be automatic and
>>>> external, so updating holidays should no longer be our concern.
>>>
>>> Are we taling about the calendar binary or the calendar files?
>>>
>>> IMHO, the calendar binary could stay in base but be modified to
>>> scan directories in e.g. /usr/local/share/calendar/ and ports
>>> could provide these calendar files.
>>
>> I have created a Phabricator review for the proposed change:
>>
>>         https://reviews.freebsd.org/D26882
>>
>> This is just an enabler for calendar files in a directory that
>> can be maintained by means of a port.
>>
>> A suggested port has been made available for review, too:
>>
>>         https://reviews.freebsd.org/D26883
>
> Modulo the stuff I left on the reviews....  I love it. I can also
> extract history from FreeBSDs repo.

The change to calendar(1) looks fine, but I have my issues with the
port.  It seems that we're not alone.  On the one hand, both Apple and
Linux have used our data files for their packages, so removing the
data files would violate POLA.  On the other hand, Apple, Linux,
NetBSD and OpenBSD are maintaining their own versions of these files,
along with calendar(1).  My guess is that Linux has them hidden on
GitHub.  I'm trying to find out where they maintain the files (can any
Linuxheads help?), so that we can come to a general agreement about
how to maintain them.  This could include removing calendar(1) from
the tree entirely and installing from a port.  Once again I'm
concerned about jumping the gun.

Greg
--
Sent from my desktop computer.
See complete headers for address and phone numbers.
This message is digitally signed.  If your Microsoft mail program
reports problems, please read http://lemis.com/broken-MUA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-arch/attachments/20201022/19f36de2/attachment.sig>