[HEADSUP] Disallowing read() of a directory fd

Cy Schubert Cy.Schubert at cschubert.com
Fri May 15 20:01:04 UTC 2020


In message <202005142017.04EKH0aA093503 at fire.js.berklix.net>, "Julian H. 
Stacey
" writes:
> Kyle Evans wrote:
> > Hi,
> > 
> > This is a heads up, given that I'm completely flipping our historical
> > behavior- I intend to commit this review in a couple days' time
> > without substantial objection: https://reviews.freebsd.org/D24596
> > 
> > With this, FreeBSD 13 will not allow read() of a directory fd, which
> > could have previously returned some data from the underlying
> > filesystem in no particular standardized format.
> > 
> > This is a still-standards-compliant switch from one
> > implementation-defined behavior to another that's already been adopted
> > in various other popular kernels, to include OpenBSD, MacOS, and
> > Linux.
> > 
> > Worth noting is that there's not really one largely-compelling reasons
> > to switch this after so many years (unless you find yourself that
> > irate when you accidentally `cat` a directory), but there are some
> > benefits which are briefly discussed in the commentary around the
> > review along with the history of the current behavior.
> > 
> > This change also simplifies filesystem implementations to some extent.
> > 
> > Thanks,
> > 
> > Kyle Evans
>
> There is ZERO need for a spurious change at 2 days notice after 42+ years !

It's been 42 or more years since this bug was introduced. Let's just fix it 
now instead of agonizing over it.


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy at nwtime.org>    Web:  https://nwtime.org

	The need of the many outweighs the greed of the few.




More information about the freebsd-arch mailing list