Veriexec

[Stephen Kiernan]

On Fri, Jul 6, 2018 at 4:29 PM, Conrad Meyer <cem at freebsd.org> wrote:

> Hi Stephen,
>
> On Fri, Jul 6, 2018 at 1:09 PM, Stephen Kiernan <hackagadget at gmail.com>
> wrote:
> > On Thu, Jul 5, 2018 at 2:06 PM, Conrad Meyer <cem at freebsd.org> wrote:
> >> (Additionally, I don't really like the use of
> >> "revert" (as used in the commit message) or "backout" (here) to
> >> describe the kernel changes.  The bad code is still present, but
> >> disabled by default.)
> >
> > What would you prefer? It helps to provide an alternative if you wish to
> > see someone potentially use it in the future. You simply stated you
> didn't
> > like the use without providing an alternative.
>
> It's a minor language quibble — don't worry about it too much.  I
> would suggest "disable by default," for example.  "Revert" and
> "backout" have a specific meaning that is approximately 'svn merge -c
> -NNNNNN'.
>
> > Note that the commit message for r335682 says "Partial revert of
> > r335399 and r335400" which is exactly what it is. It wasn't a full revert
> > of the commits, it was only partially reverting them.
>
> It removes 7 lines out of 2856 lines added in the two commits.  I
> agree that you're technically correct — it is a partial revert.  But I
> think it would be more clear and accurate not to describe it as any
> kind of revert, given how little (0.25% of lines) was actually
> removed.
>

Fair enough.

Thanks.
-Steve