[rfc] add MK_TELNET_SSL as a build option

[Garrett Cooper]

On Jun 13, 2015, at 15:40, Adrian Chadd <adrian at freebsd.org> wrote:

> Hi,
> 
> The wifi builds have a need for building telnet/telnetd without
> ssl/kerberos in order to meet size constraints and to allow them to be
> crunch’ed.

...

> ===================================================================
> --- contrib/telnet/libtelnet/misc-proto.h       (revision 284291)
> +++ contrib/telnet/libtelnet/misc-proto.h       (working copy)
> @@ -71,6 +71,11 @@
> /*
>  * These functions are imported from the application
>  */
> +/*
> + * XXX TODO: turn into a function set that's passed in
> + * from telnet/telnetd main().  That way it can be
> + * built via crunchgen.
> + */

What’s the story behind the TODO?

> ===================================================================
> --- lib/libtelnet/Makefile      (revision 284291)
> +++ lib/libtelnet/Makefile      (working copy)
> @@ -15,7 +15,7 @@
> 
> WARNS?=                2
> 
> -.if ${MK_OPENSSL} != "no"
> +.if ${MK_OPENSSL} != "no" && ${MK_TELNET_SSL} != “no"

Please reduce this to ${MK_TELNET_SSL} != “no” (here and elsewhere). ${MK_OPENSSL} == “no” already handles setting this knob in src.opts.mk, so there’s no reason why you need to check both knobs.
Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/freebsd-arch/attachments/20150613/730ced2d/attachment.sig>