Using sys/types.h types in sys/socket.h

[Adrian Chadd]

Hi,


On 10 January 2014 03:38, Bruce Evans <brde at optusnet.com.au> wrote:
>> /*
>> * sendfile(2) kqueue information
>> */
>> struct sf_hdtr_kq {
>>        __uintptr_t kq_ident;   /* ident (from userland?) */
>>        void    *kq_udata;      /* user data pointer */
>>        __uint32_t kq_flags;    /* extra flags to pass in */
>>        int     kq_fd;  /* kq fd to post completion events on */
>> };
>>
>> Ok, so I've removed one tab from the comments and added a tab after
>> void/int.
>>
>> How's that?
>
>
> Now the last comment is misindented.

Ok, I'll fix that.

> This also has the unrelated change of using __ufoo instead of ufoo.  I
> think that is only correct if the types are supposed to be almost opaque,
> with the details not part of the API.

Peter raised a point on irc - if I define uint32_t/uintptr_t in the
header, then code that includes sys/socket.h will be able to use
uint32_t / uintptr_t without including sys/types.h.

What should be done there?



-a