[rfc] sendfile: refactor out common sendfile code into _do_sendfile()

[Xin Li]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 01/07/14 16:56, Adrian Chadd wrote:
> Hi,
> 
> http://people.freebsd.org/~adrian/netflix/20140107-freebsd-sendfile-refactor-1.diff
>
>  This refactors out the common code from both the sendfile and
> compat32 sendfile calls into a shared function. That way I can
> extend the sendfile behaviour and only have to update one
> location.
> 
> What do people think?

I think this would be a good idea, but can we call _do_sendfile
something different?  (Maybe call the current do_sendfile
"sendfile_common", and _do_sendfile "do_sendfile"?)

('compat' seems to be a bad name, by the way.  Maybe we can just get
rid of the inner test and just pass SFK_COMPAT as 'flag'?)

Cheers,
- -- 
Xin LI <delphij at delphij.net>    https://www.delphij.net/
FreeBSD - The Power to Serve!           Live free or die
-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJSzKk3AAoJEJW2GBstM+nskVsP/jMTYp8yHH650N2o0CJ5Goly
SWZSPSGdgsOtL1XifX5pkO77KuR6/3IP5dr3ilUlaYHT0HK1Y5+gKPOW+cgcaPAQ
+RjVMCxtfnugo3VE5zI6H4cvxgPxXISynSr7zaQ5WUlC3moTLxrpZ8wOwvkDEwIC
V/Rlb4y0ohHXezH3aBgdCP41jkOxYjCgQjHxviexDcv8zMlgi9CCOxoihFaPczwW
8I0E8RPzyIHZVIZtFnHYpomaFsHAJxR7KJjc9YUGnyTdSnwKwEYv5PON0BYM7NVX
erG9vK9ro7hRV5ZELlxc1GsdgKQZ2JUkJr0vT1VKP55LHgsxwPIzfySHiqHV3RTc
s2el2ps0kP9rU9E5M5KIsV59RAo4Wzu53bIohg1hf02VBAPbSUe0ATqM+wxgb5MB
oiA2zyw3bmRdSmAIttda2F+bAQkZpPaur3PnJuxicktvEeX+CuqeXHZfebFSKVvi
B2QR6KCSsMRJhYJn7FVnL2pbTAOur/EmLudYHngnQc8UK3YBBIt+7KOirOEIwyd0
WPU9Rp21UGXTTm3uy0WyQs3yrDeFaHE2ebhczV2PLdFSSqqif53pw3xGTwRQBHW0
BP9QcNEribvsHdMqdr9Fv6/vBXosVzleUmG2raM+vvIHrOGVP8diVGOOAqGXdBtW
Q5nZoSc9nBEteTuGZs2N
=OBCI
-----END PGP SIGNATURE-----