Libxo bugs and fixes.

Alfred Perlstein bright at mu.org
Thu Dec 25 18:01:29 UTC 2014


On 12/25/14 9:31 AM, Simon J. Gerraty wrote:
> Alfred Perlstein <bright at mu.org> wrote:
>> Yes, the patch leaves it to the caller. The otherwise when you run "netstat --libxo json 1" you only see output every BUFSIZE bytes from netstat.
> I was refering to the call to xo_flush in xo_emit.
> The application best knows what are suitable points at which to flush
> its output.
> If you eliminate that call, it might be ok
>
I don't think my patch adds an xo_flush to xo_emit...  ?

Did I miss something?

Yes, there is an explicit flush at the end of xo_message_hcv() but that 
should be harmless or possibly removed since the output channel for 
warnings should be unbuffered.

-Alfred


More information about the freebsd-arch mailing list