Proposal: Unify printing the function name in panic messages()

Christoph Mallon christoph.mallon at gmx.de
Sat Feb 9 09:28:53 UTC 2013


On 09.02.2013 10:08, Andriy Gapon wrote:
> In any case, you just search the code for the message and that's it.

Often the messages contains parameters (%d, %s, ...) or are split into multiple lines to appease the ancient 80 columns god.
These make it harder to grep.
Having the /right/ name makes it easier to get to the right place.

> If this is a solution in search of a problem, then I don't like it, because it

The two problems this change solves are very simple:
- There are needlessly about a dozen different ways used to add the function name into the panic message.
  This change unifies it.
- All too often the name is wrong.
  This change gets it right every time without any manual and error-prone effort of somebody, who adds a use of PANIC().

> requires massive, if mostly mechanical, changes throughout the code.

I do not understand, what the problem is.
There are bugs and cumbersome code.
This simple changes solves it.

	Christoph


More information about the freebsd-arch mailing list