Fallout from the CVS discussion

[Warner Losh]

On Sep 18, 2012, at 2:27 PM, Baptiste Daroussin wrote:

> On Mon, Sep 17, 2012 at 06:03:24PM -0400, Eitan Adler wrote:
>> On 17 September 2012 17:52, Warner Losh <imp at bsdimp.com> wrote:
>> [snip]
>> 
>>>>>> There is a compromise solution here that I have been hesitant to offer
>>>>>> because I was really hoping that sanity would prevail. But why not
>>>>>> switch the default MK_CVS knob over to "no" now? That will give us an
>>>>>> opportunity to see if there really will be any fallout, and easily fix
>>>>>> it if there is.
>>>>> 
>>>>> I believe that's already been done.
>>>> 
>>>> It isn't now, but it sounds to me like you're saying that you're not
>>>> opposed to doing so?
>>> 
>>> MK_CVS moving to 'no' by default is something we can do right away, since it is easy to figure out what went wrong for the people using cvs and putting it back w/o needing to download anything new.  Living behind firewalls can make downloads a pita.  I have had systems with very specific holes that made it a PITA to download anything to them, and it is a common occurrence.
>>> 
>>>> Eitan, if you're listening, I'd strike while the iron is hot. :)
>>> 
>>> Since I thought that had already been done, please do so.  Please make sure that ObsoleteFiles does the right thing too :)  Oh, and make sure UPDATING is updated.
>> 
>> I have some surrounding commits to get done first. I'd like to get
>> some of the existing documentation that refers to CVS removed or
>> modified first.
>> There is some consensus for making MK_CVS default to "no" early, so
>> I'll take that into account and commit that sooner than the above
>> listed conditions.
>> Does this change require a OSVERSION bump?  I'm inclined to say yes as
>> the ports infrastructure might need to be aware of the change.
>> 
> What for?
> 
> I don't see any reason why the ports tree would like to know about the cvs
> removal, do you have something in mind?


The following ports define CVS_CMD, or have a naked 'cvs' call in them.

japanese/man_doc
misc/shuffle
net_mgt/rancid
net_mgt/rancid-devel
sysutils/readlink
www/tidy-devel

all appear to use the system cvs to check out the sources (except many rancid, not sure what to make of that).

Warner