bsd.own.mk - just let WITHOUT_* take precedence

[David O'Brien]

On Mon, Oct 08, 2012 at 10:48:53AM -0500, Brooks Davis wrote:
> On Sat, Oct 06, 2012 at 05:14:23PM -0700, Simon Gerraty wrote:
> > After being bitten by:
> > make: "/b/sjg/work/fbsd-head/src/share/mk/bsd.own.mk" line 490: WITH_CTF
> > and WITHOUT_CTF can't both be set.
...
> I'm not sure if I agree or not, I'll have to think more.  This sort of
> thing that leads to me yelling at my computer "but I @#%$@# set
> WITH_FOO you ^@$@! machine." :)

Brooks,
Isn't that what some folks are currently doing trying to build a fully
DTrace ready system?

Have you had a chance to review Simon's latest diff?

This is the only build knob I'm aware of where setting it manually in the
environment doesn't work the same as setting it in /etc/{src,make}.conf.

Its been too hard to build a fully DTrace-ready FreeBSD for a long time.
We really need closure on this -- DTrace is too useful.


Note that our Handbook () still has:

    <!-- XXXTR: WITH_CTF has been reported to leave a user with a
         broken system when used with buildworld.  Until this is
         fixed, comment out those parts.  When uncommenting, kill
         the extra screen.
    -->

    <screen>&prompt.root; <userinput>cd /usr/src</userinput>
    <!-- &prompt.root; <userinput>make WITH_CTF=1 buildworld</userinput> -->
    &prompt.root; <userinput>make WITH_CTF=1 kernel</userinput></screen>
    <!-- &prompt.root; <userinput>make WITH_CTF=1 installworld</userinput>
    &prompt.root; <userinput>mergemaster -Ui</userinput></screen> -->


We really need to make this as easy as possible for users and get the
docs matching reality.

-- 
-- David  (obrien at FreeBSD.org)