Where should I put ar71xx_* modules?

[Stefan Bethke]

Am 09.01.2012 um 09:39 schrieb Adrian Chadd:

> On 8 January 2012 23:59, Stefan Bethke <stb at lassitu.de> wrote:
>> Am 09.01.2012 um 00:42 schrieb Adrian Chadd:
>> 
>>> Hi,
>>> 
>>> In order to fit an lzma'd kernel in 892 kilobytes of flash (that's 892
>>> * 1024 bytes), I've needed to break out a few things into modules.
>>> 
>>> I'd like to commit a couple of modules - for example,
>>> ar71xx_ehci/ar71xx_ohci for USB stuff - but I don't want them built
>>> for anything other than ar71xx builds. Thus I don't see the reason for
>>> putting them in sys/modules/Makefile.
>>> 
>>> They build fine if they're included in MODULES_OVERRIDE in the
>>> relevant kernel config file.
>>> 
>>> So is it ok to just commit some modules in sys/modules/ which aren't
>>> in the Makefile, and instead include them in the relevant SoC kernel
>>> configs so they're built? Or is there some other tradition for doing
>>> this?
>> 
>> Why would it hurt to have them connected to the standard build?  Doe the tinderboxes build modules?
> 
> Because they have to compile only for MIPS? And they'd only work for ar71xx?

We have lots of modules that have specific requirements; they're still connected to the build.  What warrants different handling here?  You could put them under .if ${MACHINE_CPUARCH} != "mips" like a number of them are already.


Stefan

-- 
Stefan Bethke <stb at lassitu.de>   Fon +49 151 14070811