stop scheduler in panic context

Andriy Gapon avg at FreeBSD.org
Wed Jun 22 17:03:52 UTC 2011


on 22/06/2011 19:58 mdf at FreeBSD.org said the following:
> On Wed, Jun 22, 2011 at 9:09 AM, Andriy Gapon <avg at freebsd.org> wrote:
>>
>> I would like to present the following diff for review and discussion:
>> http://people.freebsd.org/~avg/stop_scheduler_on_panic.diff
> 
> The idea seems sound to me, but I don't see any bits in sched_4bsd.c
> or sched_ule.c to prevent other threads from running.  Or does that
> already happen when panicstr != NULL?

I think that that should happen automatically as a result of stop_cpus_hard plus
disabling interrupts on the panic-ing CPU.

>> The idea is to stop scheduler in a panic context and to provide a special
>> environment for the only running thread, the one that called panic(9).
>>
>> I tried to make this diff as minimal as possible, it doesn't include changes that
>> I consider to be useful improvements and [even] bug fixes, but which generated
>> controversy in non-public discussions.
>>
>> If there is no negative feedback within next few days, then I plan to post the
>> patch to current@ to solicit some testing.  I will definitely wait for positive
>> feedback before committing this change.  I hope that I will be able to sneak it
>> into the 9 release (unless there are objections to this).
>>
>> Thank you!
>> --
>> Andriy Gapon
>> _______________________________________________
>> freebsd-arch at freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/freebsd-arch
>> To unsubscribe, send any mail to "freebsd-arch-unsubscribe at freebsd.org"
>>


-- 
Andriy Gapon


More information about the freebsd-arch mailing list