Is there any reason not to remove all the spl() calls in rtsock.c?

[Warner Losh]

On Apr 25, 2011, at 8:09 PM, Ryan Stone wrote:

> On Mon, Apr 25, 2011 at 9:59 PM, George Neville-Neil
> <gnn at neville-neil.com> wrote:
>> Howdy,
>> 
>> I was just reviewing the code in rtsock.c, specifically rts_attach().  Is there any reason
>> not to just remove the spl* calls?  I don't see anything obvious that needs protection
>> that is not now protected by a finer grained lock.

Likely they can go.  Only reason to keep them at all at this point is if there's still stuff that isn't locked, which should be only a tiny fraction of the tree...

Warner

>> 
>> Best,
>> George
> 
> The spl* calls have been no-ops for over 10 years now(since r71240),
> so I certainly hope that there's nothing requiring their protection.
> 
> It's probably long-past time to kill off those stubs, I'd imagine.
> _______________________________________________
> freebsd-arch at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-arch
> To unsubscribe, send any mail to "freebsd-arch-unsubscribe at freebsd.org"
> 
>