CTF patch for testing/review

[John Baldwin]

On Thursday 25 March 2010 5:56:15 am Alexander Leidinger wrote:
> Quoting John Baldwin <jhb at freebsd.org> (from Wed, 24 Mar 2010 11:32:29 
-0400):
> 
> > On Wednesday 24 March 2010 10:42:14 am Alexander Leidinger wrote:
> >> Quoting John Baldwin <jhb at freebsd.org> (from Wed, 24 Mar 2010 10:05:55
> > -0400):
> >>
> >> > On Wednesday 24 March 2010 9:59:41 am Alexander Leidinger wrote:
> >>
> >> >> Currently I have the problem that WITH_CTF is not picked up by kmod.mk
> >> >> if "makeoptions WITH_CTF=yes" is used in the kernel config. This means
> >> >> that all makeoptions do not propagate to module builds.
> >> >>
> >> >> Any ideas?
> >> >
> >> > Hmmmm.  That's odd because 'DEBUG=-g' does work.  Ah, I think you 
should
> >> > patch kern.post.mk to propogate WITH_CTF to modules.  This is how it 
works
> >> > for DEBUG now:
> >> >
> >> > .if defined(DEBUG)
> >> > MKMODULESENV+=  DEBUG_FLAGS="${DEBUG}"
> >> > .endif
> >>
> >> Do we want to be able to override WITH_CTF in modules (-> kern.pre.mk
> >> instead of kernl.post.mk)?
> >
> > No, I think it is fine to treat it the same as DEBUG.
> 
> DEBUG is in kern.pre.mk, and thus can be overriden. Currently I have  
> WITH_CTF handling in kern.post.mk, and thus it can not be overriden.  
> There are some MKMODULESENV things in post.mk already.

Ok.

> On a related note, the LD_CTF_FLAGS thing does not seem to work for  
> modules. Reading the man page of ld tells that -g is a noop (the  
> switch is ignored). Thus I would prefer to remove the setting of -g  
> for ld. Any objections?

Ok.

-- 
John Baldwin