CTF patch for testing/review

John Baldwin jhb at freebsd.org
Wed Mar 24 19:23:50 UTC 2010


On Wednesday 24 March 2010 10:42:14 am Alexander Leidinger wrote:
> Quoting John Baldwin <jhb at freebsd.org> (from Wed, 24 Mar 2010 10:05:55 
-0400):
> 
> > On Wednesday 24 March 2010 9:59:41 am Alexander Leidinger wrote:
> 
> >> Currently I have the problem that WITH_CTF is not picked up by kmod.mk
> >> if "makeoptions WITH_CTF=yes" is used in the kernel config. This means
> >> that all makeoptions do not propagate to module builds.
> >>
> >> Any ideas?
> >
> > Hmmmm.  That's odd because 'DEBUG=-g' does work.  Ah, I think you should
> > patch kern.post.mk to propogate WITH_CTF to modules.  This is how it works
> > for DEBUG now:
> >
> > .if defined(DEBUG)
> > MKMODULESENV+=  DEBUG_FLAGS="${DEBUG}"
> > .endif
> 
> Do we want to be able to override WITH_CTF in modules (-> kern.pre.mk  
> instead of kernl.post.mk)?

No, I think it is fine to treat it the same as DEBUG.

> While I'm here, do we want to have CONF_CFLAGS used in modules too? I  
> would expect that they are used there (I use it to use -fno-builtin  
> for my kernel build) and would put it into kern.post.mk.

Hmm, probably yes.  That should be a separate commit however.

-- 
John Baldwin


More information about the freebsd-arch mailing list