[PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch

[Attilio Rao]

2010/2/16 Kostik Belousov <kostikbel at gmail.com>:
> On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote:
>> The following patch:
>> http://www.freebsd.org/~attilio/x86.diff
>>
>> starts the effort for having a shared sub-tree between amd64 and ia32.
>> In this initial pass I putted the low-hanging fruits (bios/cpufreq)
>> and what my customer was more interested in (isa/*) in order to
>> kick-off the effort and, in the future, move gradually the code there.
>> With the machine/isa/* cleanup about 10 files are trimmed and I'm sure
>> more can be achieved easilly.
>> There are few things to discuss. One, that I had not necessity to dig
>> about still, is about how to organize headers (include/). Maybe some
>> replication ala pc98 may be good.
>>
>> The patch is big but it is mostly added and removed files (look at the
>> files.X in order to understand better how files movements happened).
>>
>> Hope to see comments and reviews.
>
> IMO the diff is unreadable. I suggest to do actual svn cp (not svn mv)
> operation now, without a review, and post a diff that should be applied
> to x86/ directory, as well as to build glue.

I'm not sure what you mean here. I also thought svn mv was keeping the
file history (the old cvsup repocopy) and handling directly the svn
del.

> The small proposition I have is to #define read_eflags() read_rflags()
> for amd64.

I thought about having an unified read_flags() but to do that pass later.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein